Conversation
moubctez
previously approved these changes
Oct 21, 2025
filipslezaklab
previously approved these changes
Oct 21, 2025
src/shared/hooks/useAddInstance.ts
Outdated
| enrollment: { start, networkInfo }, | ||
| } = useEnrollmentApi(); | ||
|
|
||
| const handleAddInstance = async (payload: AddInstancePayload, rawLink?: string) => { |
Contributor
There was a problem hiding this comment.
this is exposed outside via hook so should be in useCallback
src/pages/client/ClientPage.tsx
Outdated
| refetchOnWindowFocus: false, | ||
| }); | ||
|
|
||
| const handleProvisioning = async (config: ProvisioningConfig) => { |
Contributor
There was a problem hiding this comment.
Maybe move this new logic to an component so it will be incapsulated on it's own rather then in ClientPage
wojcik91
dismissed stale reviews from filipslezaklab and moubctez
via
306e3b3
filipslezaklab
approved these changes
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to trigger the enrollment process for uninitialized clients by providing the enrollment config through a file.
A client is assumed to be uninitialized if there are no instances configured in the DB. Only then do we check for the existence of the enrollment config.
Partially resolves #598